Gate commit-updated-env in push-pull#175
Merged
Merged
Conversation
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
And let the other tests run if it got skipped. This will kill its ability to run on dependabot PRs, since those come from a fork and thus different repo name, but for some reason, even with the token propagation in dependabot PRs was spotty anyhow #77 Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Member
Author
|
I don't have a from-fork test, but the new if-clauses haven't borked standard intra-repo PRs: pyiron/bagofholding#132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that it only works on PRs from inside the repo. My goal is to get PRs from forks to run here. This has the side effect of stopping PRs from dependabot from propagating their updates to secondary env files, but frankly that was spotty to start with, cf. the closed issue linked.
Closes #77