Skip to content

Update pylammpsmpi to 0.2.36#490

Merged
jan-janssen merged 5 commits intomainfrom
pylammpsmpi
Jul 6, 2025
Merged

Update pylammpsmpi to 0.2.36#490
jan-janssen merged 5 commits intomainfrom
pylammpsmpi

Conversation

@jan-janssen
Copy link
Copy Markdown
Member

@jan-janssen jan-janssen commented Jul 6, 2025

Summary by CodeRabbit

  • Chores
    • Updated the pylammpsmpi package version to 0.2.36 across all relevant environment and configuration files.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 6, 2025

Walkthrough

The version of the pylammpsmpi package was updated to 0.2.36 across multiple environment and configuration files, including optional dependency groups in pyproject.toml. No other dependencies or configuration changes were made.

Changes

File(s) Change Summary
.ci_support/environment-docs.yml
.ci_support/environment-lammps.yml
binder/environment.yml
Updated pylammpsmpi version from 0.2.35 to 0.2.36.
.ci_support/environment-notebooks.yml Updated pylammpsmpi version from 0.2.31 to 0.2.36.
pyproject.toml Updated pylammpsmpi in lammps and lammps_phonons optional groups from 0.2.35 to 0.2.36.

Possibly related PRs

Suggested labels

dependencies

Poem

A hop and a skip, a version ascends,
pylammpsmpi grows, the update never ends.
From thirty-five to thirty-six,
In every file, the numbers mix!
The rabbit approves, with a twitch of its nose—
Dependency gardens, how swiftly they grow!
🐇✨

Warning

Review ran into problems

🔥 Problems

Check-run timed out after 90 seconds. Some checks/pipelines were still in progress when the timeout was reached. Consider increasing the reviews.tools.github-checks.timeout_ms value in your CodeRabbit configuration to allow more time for checks to complete.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
.ci_support/environment-docs.yml (1)

8-12: Duplicate numpy entries will confuse the solver

Lines 8-11 list - numpy and a pinned - numpy =1.26.3. Mixed pinning frequently forces conda into lengthy backtracking or outright resolution errors.

Apply this minimal diff:

- - numpy
- - ase =3.25.0
- - coverage
- - numpy =1.26.3
+ - ase =3.25.0
+ - coverage
+ - numpy =1.26.3   # keep only the pinned version

Repeat the cleanup for other duplicated packages if they appear elsewhere.

🧹 Nitpick comments (1)
pyproject.toml (1)

49-56: Keep version pin in sync with conda environments automatically

Hard-coding the same version string in multiple places (two extras here plus four env files) is error-prone. Consider introducing a single pylammpsmpi version variable in pyproject.toml and reference it from the CI templates via hatch/tox or a small templating step to avoid future drift.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1257437 and 8eca571.

📒 Files selected for processing (5)
  • .ci_support/environment-docs.yml (1 hunks)
  • .ci_support/environment-lammps.yml (1 hunks)
  • .ci_support/environment-notebooks.yml (1 hunks)
  • binder/environment.yml (1 hunks)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
  • GitHub Check: unittest_siesta
  • GitHub Check: unittest_abinit
  • GitHub Check: unittest_qe
  • GitHub Check: unittest_matrix (ubuntu-latest, 3.10)
  • GitHub Check: unittest_matrix (ubuntu-latest, 3.11)
  • GitHub Check: unittest_matrix (ubuntu-latest, 3.12)
  • GitHub Check: unittest_matrix (macos-latest, 3.12)
  • GitHub Check: unittest_matrix (windows-latest, 3.12)
  • GitHub Check: unittest_old
  • GitHub Check: unittest_matgl
  • GitHub Check: unittest_mace
  • GitHub Check: unittest_gpaw
  • GitHub Check: unittest_sphinxdft
  • GitHub Check: notebooks
  • GitHub Check: coverage
🔇 Additional comments (4)
binder/environment.yml (1)

14-14: Confirmed pylammpsmpi==0.2.36 is available on conda-forge

Verified via the Anaconda API that version 0.2.36 of pylammpsmpi is already published to the conda-forge channel. No changes needed—merging can proceed safely.

.ci_support/environment-docs.yml (1)

19-19: Rebuild docs image – pylammpsmpi==0.2.36 is available on conda-forge

Confirmed via the Anaconda.org API that version 0.2.36 of pylammpsmpi is published on the conda-forge channel. You can safely proceed with rebuilding the documentation image.

• Location: .ci_support/environment-docs.yml:19

.ci_support/environment-notebooks.yml (1)

9-9: Check compatibility of the new version with the notebook stack

Notebook examples import pylammpsmpi together with gpaw 24.6.0 and lammps 2024.06.27. A minor version bump is usually safe, but verify that 0.2.36 still links against the same LAMMPS release to avoid runtime symbol errors inside the MPI wrapper.

.ci_support/environment-lammps.yml (1)

7-7: Confirm binary compatibility with the pinned lammps build

pylammpsmpi is a Python wrapper compiled against a specific LAMMPS (and MPI) build. Moving from 0.2.350.2.36 while keeping lammps=2024.06.27=*openmpi* should be fine, but double-check the conda-forge feedstock notes/changelog to ensure no ABI bump occurred.

@jan-janssen jan-janssen changed the title Update pylammpsmpi Update pylammpsmpi to 0.2.36 Jul 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.27%. Comparing base (1257437) to head (8eca571).
⚠️ Report is 135 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files          43       43           
  Lines        2581     2581           
=======================================
  Hits         2201     2201           
  Misses        380      380           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 759a224 into main Jul 6, 2025
50 of 51 checks passed
@jan-janssen jan-janssen deleted the pylammpsmpi branch July 6, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant