Conversation
WalkthroughThe updates increase the version of the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pyproject.toml (1)
68-68: Minor naming inconsistency: “sphinx-parser” vs “sphinx_parser”The PyPI canonical name uses a hyphen, while the Conda recipe typically mirrors it (
sphinx-parser).
Although pip/Conda normalise hyphens and underscores, using the same spelling across files avoids confusion when troubleshooting dependency issues. Consider switching the Conda pin tosphinx-parserfor consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.ci_support/environment.yml(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: unittest_old
| - spglib =2.6.0 | ||
| - structuretoolkit =0.0.32 | ||
| - sphinx_parser =0.0.1 | ||
| - sphinx_parser =0.0.2 |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Verify that 0.0.2 is actually on conda‐forge before merging
CI will fail early if the new pin isn’t published yet.
You can check availability quickly via the repodata API:
🏁 Script executed:
#!/bin/bash
# Search conda-forge repodata for the exact 0.0.2 build
curl -s https://conda.anaconda.org/conda-forge/noarch/repodata.json |
jq -r '.packages | keys[]' | grep -E '^sphinx-parser-0\.0\.2'Length of output: 133
To ensure we’re matching the actual filenames in repodata (which include the build string), let’s retry with a pattern that covers the full file key:
🏁 Script executed:
#!/bin/bash
curl -s https://conda.anaconda.org/conda-forge/noarch/repodata.json \
| jq -r '.packages | keys[]' \
| grep -E '^sphinx[-_]parser-0\.0\.2-'Length of output: 137
Let’s check via the Anaconda.org API for sphinx-parser releases:
🏁 Script executed:
#!/bin/bash
# Query conda-forge’s Anaconda.org package metadata for sphinx-parser
curl -s https://api.anaconda.org/package/conda-forge/sphinx-parser \
| jq -r '.releases[].version' \
| sort -u \
| grep -x '0\.0\.2'Length of output: 186
Hold merge – sphinx-parser 0.0.2 isn’t on conda-forge yet
I checked both the conda-forge repodata and the Anaconda.org API and found no 0.0.2 release. Merging this pin now will break CI.
• File: .ci_support/environment.yml, line 16
• Action: either pin a version that exists (e.g. 0.0.1) or wait until 0.0.2 is published before merging.
🤖 Prompt for AI Agents
In .ci_support/environment.yml at line 16, the package sphinx_parser is pinned
to version 0.0.2, which is not yet available on conda-forge and will break CI.
To fix this, change the version pin to an existing release such as 0.0.1 or
remove the version pin temporarily until 0.0.2 is officially published on
conda-forge.
|
@samwaseda It seems Python 3.10 is no longer supported: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 85.27% 85.27%
=======================================
Files 43 43
Lines 2581 2581
=======================================
Hits 2201 2201
Misses 380 380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary by CodeRabbit