Remove manual .condarc by jan-janssen · Pull Request #511 · pyiron/atomistics

jan-janssen · 2025-07-28T18:00:28Z

Summary by CodeRabbit

Chores
- Updated environment setup in workflows to configure conda channels using built-in action parameters instead of manual file creation. No changes to user-facing features or behavior.

coderabbitai · 2025-07-28T18:00:36Z

Walkthrough

The pull request updates GitHub Actions workflows by removing manual creation of .condarc files for conda channel configuration. Instead, it configures the setup-miniconda action directly with channels: conda-forge and conda-remove-defaults: "true", streamlining channel setup across all relevant jobs.

Changes

Cohort / File(s)	Change Summary
Deploy Workflow Channel Setup `.github/workflows/deploy.yml`	Removed manual `.condarc` creation; now uses `setup-miniconda` action parameters for channel configuration.
Pipeline Workflow Channel Setup `.github/workflows/pipeline.yml`	Replaced all `.condarc` file steps with direct `setup-miniconda` action parameters across all conda setup jobs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Remove conda default channel #332: Both PRs modify GitHub Actions workflows to change how conda channels are configured by replacing manual .condarc file creation with direct setup-miniconda action parameters or vice versa, focusing on the same workflow files and channel setup steps.

Poem

🐇
No more .condarc to write by hand,
Channels set with a single command!
Miniconda’s setup, now quick and neat,
Workflows hopping to a streamlined beat.
With less YAML and fewer lines,
The CI garden grows—how fine!
🌱✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch conda_env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (1)

.github/workflows/pipeline.yml (1)

90-94: Same channel tweaks repeated in many jobs
These hunks replicate the change already reviewed above; the comment applies equally here.

Also applies to: 116-120, 142-146, 190-194, 216-220, 244-248, 270-274, 296-300, 324-328, 352-356, 378-381, 404-406, 434-438, 455-458

🧹 Nitpick comments (1)

.github/workflows/pipeline.yml (1)
58-62: Repeated environment-setup boilerplate – consider a YAML anchor or composite action
The same three inputs (python-version, channels, conda-remove-defaults) are copied into every job. Defining them once via
  .miniconda: &miniconda
    uses: conda-incubator/setup-miniconda@v3
    with:
      python-version: ${{ matrix.python-version || '3.12' }}
      miniforge-version: latest
      channels: conda-forge
      conda-remove-defaults: "true"
and re-using with <<: *miniconda (or converting to a composite action) would reduce duplication and future drift.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f88d032 and 162e1f5.

📒 Files selected for processing (2)

.github/workflows/deploy.yml (1 hunks)
.github/workflows/pipeline.yml (15 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

GitHub Check: unittest_siesta
GitHub Check: unittest_old
GitHub Check: unittest_mace
GitHub Check: unittest_matrix (windows-latest, 3.12)
GitHub Check: unittest_gpaw
GitHub Check: unittest_matrix (ubuntu-latest, 3.12)
GitHub Check: unittest_matrix (ubuntu-latest, 3.11)
GitHub Check: unittest_matrix (macos-latest, 3.12)
GitHub Check: unittest_qe
GitHub Check: unittest_sphinxdft
GitHub Check: unittest_matgl
GitHub Check: notebooks
GitHub Check: coverage

🔇 Additional comments (1)

.github/workflows/deploy.yml (1)

26-27: Built-in channel configuration is a clean replacement for the old .condarc step – LGTM
Using the channels: conda-forge and conda-remove-defaults: "true" inputs directly in setup-miniconda removes an extra maintenance point. The quoted "true" matches the action’s boolean-string convention.

jan-janssen · 2025-07-28T18:07:25Z

Supersedes #433

codecov · 2025-07-28T18:11:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.75%. Comparing base (f88d032) to head (162e1f5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   85.34%   85.75%   +0.41%     
==========================================
  Files          43       43              
  Lines        2586     2570      -16     
==========================================
- Hits         2207     2204       -3     
+ Misses        379      366      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Remove manual .condarc

162e1f5

coderabbitai bot reviewed Jul 28, 2025

View reviewed changes

jan-janssen merged commit 111ff64 into main Jul 28, 2025
28 checks passed

jan-janssen deleted the conda_env branch July 28, 2025 18:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove manual .condarc#511

Remove manual .condarc#511
jan-janssen merged 1 commit intomainfrom
conda_env

jan-janssen commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

jan-janssen commented Jul 28, 2025

Uh oh!

codecov bot commented Jul 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jan-janssen commented Jul 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

jan-janssen commented Jul 28, 2025

Uh oh!

codecov bot commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jan-janssen commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jul 28, 2025 •

edited

Loading