-
Notifications
You must be signed in to change notification settings - Fork 4
Update scipy to 1.16.2 #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDependency versions updated: SciPy from 1.15.2 to 1.16.2 across CI, binder, and project config; NumPy from 2.3.2 to 2.3.3 in binder environment. No other lines changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
binder/environment.yml (1)
5-6: Align Binder lammps package pins with pyproject optional dependenciesbinder/environment.yml currently pins
- pylammpsmpi =0.3.2 (line 14)
- pyiron_lammps =0.4.6 (line 18)
while pyproject.toml optional dependencies use
- pylammpsmpi==0.3.3
- pyiron_lammps==0.4.7
Update these versions in
binder/environment.ymlto match and avoid drift in tutorials..ci_support/environment.yml (1)
12-12: Add CI dry-run to validate SciPy/NumPy pins
Include amamba env create --name test --file .ci_support/environment.yml --dry-runjob to catch unintended downgrades after bumping SciPy to 1.16.2 with NumPy locked at 2.3.3.pyproject.toml (1)
29-29: Validate SciPy 1.16.2 compatibility and optimize build-system.requires
- SciPy 1.16.2 supports Python 3.11–3.13 and requires NumPy ≥1.25.2; current pins (SciPy==1.16.2, NumPy==2.3.3) are consistent across environments.
- Consider trimming
[build-system].requiresto only include hatchling and hatch-vcs to prevent pulling runtime dependencies into build isolation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.ci_support/environment-docs.yml(1 hunks).ci_support/environment.yml(1 hunks)binder/environment.yml(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: unittest_old
- GitHub Check: notebooks
- GitHub Check: unittest_siesta
- GitHub Check: unittest_orb
- GitHub Check: unittest_matrix (ubuntu-latest, 3.11)
- GitHub Check: unittest_mace
- GitHub Check: unittest_grace
- GitHub Check: unittest_sphinxdft
- GitHub Check: unittest_qe
- GitHub Check: unittest_matrix (ubuntu-latest, 3.12)
- GitHub Check: unittest_matrix (macos-latest, 3.12)
- GitHub Check: unittest_gpaw
- GitHub Check: coverage
🔇 Additional comments (1)
.ci_support/environment-docs.yml (1)
11-11: Docs env SciPy bump LGTM; no direct SciPy imports in docs.
Run a Sphinx build to catch any deprecation warnings from SciPy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 43 43
Lines 2591 2591
=======================================
Hits 2221 2221
Misses 370 370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Chores
Tests