Closed
Conversation
0db6e27 to
e590593
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## base_client #29 +/- ##
================================================
+ Coverage 50.00% 89.30% +39.30%
================================================
Files 10 17 +7
Lines 396 449 +53
================================================
+ Hits 198 401 +203
+ Misses 198 48 -150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Sorry, I rebased the branch onto the updated base ( |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Ontodocker service client via porting from branch "refactor_project_structure":
courier/services/ontodocker/*modules with the full implementation (client wiring + endpoints/datasets/SPARQL resources + models).courier.transport.url.join_url) and fixed minor upload_graph Turtle serialization/file-writing behavior.OntodockerClient: tests client wiring plus resource behavior/validation: URL construction and request dispatch for endpoints/datasets/SPARQL (incl. legacy endpoint parsing/rectification and token header propagation), using a fake session instead of real HTTP.ontodocker.pyas a compatibility wrapper aroundcourier.services.ontodocker.OntodockerClientand_compathelpers._warn_deprecated(...)(emitsDeprecationWarning,stacklevel=2)._compat(rectify_endpoints,extract_dataset_names,make_dataframe).tests/unit/test_ontodocker_legacy_shim.pyto verify delegation toOntodockerClientand expected warnings/behaviors.courier/__init__.pyOntodockerClientat top level:courier.OntodockerClient.notebooks:HttpClientandOntodockerClient. Uses mock-ups to avoid relying on actually running services.