-
Notifications
You must be signed in to change notification settings - Fork 3
Execute notebooks individually #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes remove a shell script that executed Jupyter notebooks and update the CI pipeline to call individual Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Pipeline
participant NP as Papermill
participant FL as Flux Service
CI->>NP: Execute Notebook 1 (1-single-node)
CI->>FL: Start Flux for Notebook 2
FL->>NP: Execute Notebook 2 (2-hpc-cluster)
CI->>FL: Start Flux for Notebook 3
FL->>NP: Execute Notebook 3 (3-hpc-job)
CI->>NP: Execute Notebook 4 (4-developer)
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 28 28
Lines 1252 1252
=======================================
Hits 1207 1207
Misses 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pipeline.yml (1)
170-174: Ensure Robust Sequential Execution and Error Handling for NotebooksThe new commands successfully execute each notebook individually using
papermilland theflux startprefix where needed. To further solidify this setup:
- Consider adding explicit error handling (for example, prepending the run block with
set -euo pipefailor using|| exit 1after critical commands) so that a failure in one notebook execution halts subsequent commands.- Verify that using
flux startto wrap the papermill commands for the HPC-related notebooks is intentional and that the flux service is correctly initialized by the time these commands are executed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.ci_support/build_notebooks.sh(0 hunks).github/workflows/pipeline.yml(1 hunks)
💤 Files with no reviewable changes (1)
- .ci_support/build_notebooks.sh
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
- GitHub Check: unittest_win
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
Summary by CodeRabbit