Skip to content

Crawler edits#156

Merged
samwaseda merged 6 commits intocrawlerfrom
crawler-edits
Feb 24, 2026
Merged

Crawler edits#156
samwaseda merged 6 commits intocrawlerfrom
crawler-edits

Conversation

@liamhuber
Copy link
Member

@samwaseda, I replaced the object_scope-replacable parts, and then took a crack at writing a crawler that returns dict[versions.VersionInfo, list[Callable]], which is the sort of symmetry I had in mind, and a splitter to get back your versioned/unversioned groupings. Claude did the tests, but I read them and they look good to me. Does this still meet your needs?

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
And return a map between the version info and the usages.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber liamhuber requested a review from samwaseda February 24, 2026 04:18
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/flowrep/crawler-edits

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.78%. Comparing base (ac96a5e) to head (ad8f016).
⚠️ Report is 7 commits behind head on crawler.

Files with missing lines Patch % Lines
flowrep/crawler.py 92.85% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           crawler     #156      +/-   ##
===========================================
- Coverage    98.82%   98.78%   -0.04%     
===========================================
  Files           28       28              
  Lines         1954     1976      +22     
===========================================
+ Hits          1931     1952      +21     
- Misses          23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samwaseda
Copy link
Member

Yep it looks really nice to me. Good that you took a look at it because I was not fully aware of flowrep.models.parsers.object_scope (which I should have been...)

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merge this one to crawler, because now that I removed my original functions it makes little sense to keep two PRs open

@samwaseda samwaseda merged commit 21eeb49 into crawler Feb 24, 2026
16 of 19 checks passed
@samwaseda samwaseda deleted the crawler-edits branch February 24, 2026 06:21
@samwaseda
Copy link
Member

Note: I just realized that I had failed to push my last changes (in which I erased analyze_.. etc.). The changes are reflected in #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants