Skip to content

Update numpy to 2.3.5#266

Merged
jan-janssen merged 3 commits intomainfrom
numpy
Nov 18, 2025
Merged

Update numpy to 2.3.5#266
jan-janssen merged 3 commits intomainfrom
numpy

Conversation

@jan-janssen
Copy link
Copy Markdown
Member

@jan-janssen jan-janssen commented Nov 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated numpy dependency to version 2.3.5
    • Removed unnecessary build-time dependencies

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 18, 2025

Walkthrough

This PR updates the NumPy dependency from version 2.3.4 to 2.3.5 across three configuration files and removes two build tool dependencies (hatchling and hatch-vcs) from the Binder environment configuration.

Changes

Cohort / File(s) Summary
NumPy version updates
.ci_support/environment.yml, binder/environment.yml, pyproject.toml
Bumped NumPy dependency from 2.3.4 to 2.3.5 across CI support, Binder, and project configuration files.
Build tool dependency removal
binder/environment.yml
Removed hatchling =1.27.0 and hatch-vcs =0.4.0 from Binder environment dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This PR consists of simple, homogeneous dependency version updates with no logic or control-flow changes. The only minor variation is the removal of two build tools from the Binder configuration, which is straightforward.

Possibly related PRs

Poem

🐰 A hop and a bump, numpy now gleams at 2.3.5,
Build tools shed like winter's coat in the binder's keep,
Dependencies dance in harmony, fresh and alive,
The warren's code stays modern and spry! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update numpy to 2.3.5' directly and clearly summarizes the main change across all modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch numpy

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (115a677) to head (c448701).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files           4        4           
  Lines         497      497           
=======================================
  Hits          473      473           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

2-10: Versioning inconsistency: numpy in build-system is unversioned while [project] dependencies are pinned.

Line 4 in build-system.requires lists unversioned "numpy", whereas line 38 in [project].dependencies pins numpy==2.3.5. For reproducibility and consistency, consider pinning numpy in the build-system as well.

Apply this diff if reproducible builds are desired:

 requires = [
     "ase", 
-    "numpy", 
+    "numpy==2.3.5", 
     "h5py", 
     "pandas", 
     "scipy", 
     "hatchling==1.27.0",
     "hatch-vcs==0.5.0",
 ]
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c327bca and c448701.

📒 Files selected for processing (3)
  • .ci_support/environment.yml (1 hunks)
  • binder/environment.yml (1 hunks)
  • pyproject.toml (1 hunks)
🔇 Additional comments (4)
binder/environment.yml (2)

1-12: Summary inconsistency: hatchling and hatch-vcs entries are still present.

The AI summary claims that hatchling =1.27.0 and hatch-vcs =0.4.0 were removed from this file, but lines 10–11 show these entries remain unchanged (no modification markers). Please clarify whether these dependencies should be removed as part of this PR.


6-6: Verify NumPy 2.3.5 availability and changelog.

Confirm that NumPy 2.3.5 is a valid, stable release and review its changelog for any breaking changes or issues that may affect this project.

.ci_support/environment.yml (1)

8-8: NumPy version bump is consistent with other environment files.

The update to NumPy 2.3.5 aligns with the changes in binder/environment.yml and pyproject.toml. Assuming NumPy 2.3.5 is verified as stable, this change is in order.

pyproject.toml (1)

36-41: Project dependencies update is well-formed.

The numpy version pin to 2.3.5 in [project].dependencies is consistent with the rest of the section and aligns with environment file updates. Pending verification of NumPy 2.3.5 stability, this change is sound.

@jan-janssen jan-janssen merged commit c0a8e9a into main Nov 18, 2025
21 checks passed
@jan-janssen jan-janssen deleted the numpy branch November 18, 2025 02:15
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant