Include validate_potential_dataframe() in public API#280
Conversation
WalkthroughA new public function Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 8 8
Lines 980 980
=======================================
Hits 909 909
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyiron_lammps/__init__.py (1)
8-12: Importingvalidate_potential_dataframeat the top level is consistent with existing potential helpersWiring this into the package namespace alongside
get_potential_by_name/get_potential_dataframelooks good and keeps the public API coherent. One optional follow‑up (inpyiron_lammps.potential, not this file): sincevalidate_potential_dataframeaccepts bothDataFrameandSeriesand returns a single row/series, consider updating its type hints/docstring so new users of this now‑public helper have an accurate contract.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyiron_lammps/__init__.py(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
pyiron_lammps/__init__.py (1)
pyiron_lammps/potential.py (3)
get_potential_by_name(349-355)get_potential_dataframe(340-346)validate_potential_dataframe(358-380)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: unittest_matrix (windows-latest, 3.14)
🔇 Additional comments (1)
pyiron_lammps/__init__.py (1)
36-36:__all__export updated correctlyAdding
validate_potential_dataframeto__all__keeps wildcard imports and API introspection in sync with the new public symbol; no issues here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.