Skip to content

Conversation

@pmrv
Copy link

@pmrv pmrv commented Nov 28, 2025

It works, but it cannot be configured yet.

See #34

It works, but it cannot be configured yet.
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/sphinx_parser/calculator

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.59%. Comparing base (8e1d73b) to head (153bf4a).

Files with missing lines Patch % Lines
sphinx_parser/calculator.py 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   88.54%   85.59%   -2.96%     
==========================================
  Files           8        9       +1     
  Lines         812      840      +28     
==========================================
  Hits          719      719              
- Misses         93      121      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen
Copy link
Member

As a reference the ASE team worked on this some time back https://gitlab.com/ase/ase/-/merge_requests/2657

@pmrv
Copy link
Author

pmrv commented Nov 28, 2025

Yeah, I snooped around in there, but as you expected it's much simpler with the parser and newer ASE infrastructure.

@pmrv
Copy link
Author

pmrv commented Nov 30, 2025

I also found the calculator implemented by FLEUR. Seems like this can be a good template for a "modern" ase calculator too.

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@samwaseda samwaseda linked an issue Nov 30, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] ASE compatible Calculator

4 participants