-
Notifications
You must be signed in to change notification settings - Fork 1
WIP: Simple ase interface #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It works, but it cannot be configured yet.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 88.54% 85.59% -2.96%
==========================================
Files 8 9 +1
Lines 812 840 +28
==========================================
Hits 719 719
- Misses 93 121 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As a reference the ASE team worked on this some time back https://gitlab.com/ase/ase/-/merge_requests/2657 |
|
Yeah, I snooped around in there, but as you expected it's much simpler with the parser and newer ASE infrastructure. |
|
I also found the calculator implemented by FLEUR. Seems like this can be a good template for a "modern" ase calculator too. |
samwaseda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks!
It works, but it cannot be configured yet.
See #34