Skip to content

Conversation

@Mr-Sunglasses
Copy link
Contributor

fix: #76

@Mariatta
Copy link
Member

@Mr-Sunglasses could you resolve the conflicts please?

@netlify
Copy link

netlify bot commented May 3, 2025

Deploy Preview for pyladiescon-portal-docs ready!

Name Link
🔨 Latest commit 4bbcff1
🔍 Latest deploy log https://app.netlify.com/projects/pyladiescon-portal-docs/deploys/681cfc8b0deceb0008189865
😎 Deploy Preview https://deploy-preview-77--pyladiescon-portal-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Mr-Sunglasses
Copy link
Contributor Author

@Mr-Sunglasses could you resolve the conflicts please?

Requesting @Mariatta for a review.

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

Thanks for the PR! Great work. I think the validation logic will help a lot.

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

There is now conflict due to the recent merge.

@Mr-Sunglasses
Copy link
Contributor Author

There is now conflict due to the recent merge.

Fixed, please review it again 😄

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

I think the changes you made with the input group got reverted during the merge.

@Mr-Sunglasses
Copy link
Contributor Author

I think the changes you made with the input group got reverted during the merge.

oh! I'll take a look at it and sync with the main branch.

@Mariatta
Copy link
Member

Mariatta commented May 6, 2025

Test are failing

@Mr-Sunglasses Mr-Sunglasses requested a review from Mariatta May 6, 2025 18:29
@Mr-Sunglasses
Copy link
Contributor Author

Test are failing

Test are failing

Fixed the tests, please review it again

cc. @Mariatta

@Mariatta
Copy link
Member

Mariatta commented May 8, 2025

Sorry, there are more merge conflicts now because I merged several other PRs that touched the files.

@Mr-Sunglasses
Copy link
Contributor Author

Sorry, there are more merge conflicts now because I merged several other PRs that touched the files.

@Mariatta fix the conflicts, please review 😄

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the thorough work. This is very helpful.

@Mariatta Mariatta merged commit f214940 into pyladies:main May 15, 2025
2 checks passed
@Mr-Sunglasses
Copy link
Contributor Author

Thank you for the thorough work. This is very helpful.

Thanks a lot, @Mariatta, for reviewing the PR during Pycon US's busy schedule. All the best for PyCon US. And again, thanks a lot for guiding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add LinkedIn URL validation in volunteer creation form.

2 participants