-
Couldn't load subscription status.
- Fork 13
Please review Day 4 - Q1. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sanjaypradeep
wants to merge
18
commits into
pylenin:master
Choose a base branch
from
sanjaypradeep:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forked form PyLenin - Q1 solved.
Day 2, Q2 solutions.. good understanding about date difference via timedelta type.
@pylenin, addressed the comments, expected output is obtained. seconds component is not included as of now, let me know if needed will update that as well.
PR for two problems. @pylenin please review.
Adding doscs/explanation about the solution. Would be helpful for someone who reads the code.
As discussed in the review, addressing those explained information. Thanks to @pylenin
… and time. Commit - program to conver the current unix timestamp to reaable date and time.
Just an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review Day 4 - Q1. @pylenin