Linter configuration and fixes #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsoubelet
added
Estimate: Normal
jgray-19
approved these changes
Jul 24, 2025
|
|
||
|
|
||
| class entrypoint(EntryPoint): | ||
| class entrypoint(EntryPoint): # noqa N801 |
There was a problem hiding this comment.
How much do we care about this naming convention?
Member
Author
There was a problem hiding this comment.
Probably a lot, considering it's the decorator used for all entrypoints and we would have to adapt all our repos for this breaking change.
I remember at the time @JoschD had reasons for keeping it like this but I can't recall at the moment.
Member
Author
|
Looks like CodeClimate binary is about to kick the bucket. I have a "replacement" ready in the common workflows, let's just say we can ignore CC complaining for now and probably move to the alternative in next PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same concept as pylhc/omc3#519, with all rules activated and fixed.