-
Notifications
You must be signed in to change notification settings - Fork 12
Import exception from pylint.exceptions instead of utils #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also tries to use the newer name (already over three years old) first. Fixes pylint-dev#15
lskillen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and we from @cloudsmith-io would be thankful. :-)
|
Looks good here as well, but I wonder if we should still keep the current import form for compatibility with |
|
From a quick check it looks like |
|
Initially I decided against the cleanup to avoid any discussion in that direction in favor of a quick release. I've pushed a second commit with the cleanup. This should allow the maintainers to either include or exclude the cleanup with minimal effort. |
|
@PCManticore as @paddycarey noted, UnknownMessageError has existed in pylint.exceptions since since 1.7.0. This library has been incidentally working for so long because pylint.utils used to import UnknownMessageError. In Pylint 2.4, pylint.utils was refactored to only expose particular functions. tl;dr, this change won't break anything older than Pylint 1.7 |
|
@carlio this broke pylint-django. Do you mind pushing a new version to PyPI. Maybe also add minimum version requirements in setup.py ? |
|
@atodorov yes, will do this later - I'm on a train at the moment so will wait for reliable internet |
|
Please note, everyone: We would need more maintainers on this project. The package on PyPI only has a single maintainer. For a package that so many people seemingly depend on we must do better. If Carl is on the train, on holiday, gone for months, <your-reason-here> this package becomes unusable for everyone. That's too risky. Pylint-django has 3 maintainers (the pyroma recommended minimum), this is already better. Pylint itself has 6. How about adding the maintainers of pylint-django also as maintainers to this package? (Sorry, if that's a creepy suggestion.) @carlio? @atodorov? @colinhowe? Or anyone else volunteering? |
|
@bittner +1 on my side, I can help maintain this project too, also push builds to PyPI. All depending on time of course but so far I've managed ;-) |
|
Version 0.6 is now on PyPI @atodorov I am happy to add you as a maintainer if you want! I think @colinhowe hasn't actually done much for pylint-django, not sure if he forgot about it :-) |
|
Hello! Sorry, I've moved city and jobs in the past few months and haven't really had free time for anything apart from decorating the house :) I'm happy to be kept on the list and be a fallback reviewer if things get clogged up. |
|
Can we get the latest |
Also tries to use the newer name (already over three years old) first.
Fixes #15