Skip to content

Conversation

@michael-k
Copy link
Contributor

Also tries to use the newer name (already over three years old) first.

Fixes #15

Also tries to use the newer name (already over three years old) first.

Fixes pylint-dev#15
Copy link

@lskillen lskillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and we from @cloudsmith-io would be thankful. :-)

@PCManticore
Copy link

Looks good here as well, but I wonder if we should still keep the current import form for compatibility with pylint<2.4

@paddycarey
Copy link

From a quick check it looks like UnknownMessageError has existed in pylint.exceptions since at least Pylint version 1.7.0 (https://github.com/PyCQA/pylint/blob/pylint-1.7.0/pylint/exceptions.py), so the import cleanup probably makes sense I think.

@michael-k
Copy link
Contributor Author

Initially I decided against the cleanup to avoid any discussion in that direction in favor of a quick release. I've pushed a second commit with the cleanup. This should allow the maintainers to either include or exclude the cleanup with minimal effort.

@kdmccormick
Copy link

kdmccormick commented Sep 26, 2019

@PCManticore as @paddycarey noted, UnknownMessageError has existed in pylint.exceptions since since 1.7.0. This library has been incidentally working for so long because pylint.utils used to import UnknownMessageError. In Pylint 2.4, pylint.utils was refactored to only expose particular functions.

tl;dr, this change won't break anything older than Pylint 1.7

@atodorov
Copy link
Contributor

@carlio this broke pylint-django. Do you mind pushing a new version to PyPI. Maybe also add minimum version requirements in setup.py ?

@carlio
Copy link
Member

carlio commented Sep 26, 2019

@atodorov yes, will do this later - I'm on a train at the moment so will wait for reliable internet

@bittner
Copy link

bittner commented Sep 27, 2019

Please note, everyone:

We would need more maintainers on this project. The package on PyPI only has a single maintainer. For a package that so many people seemingly depend on we must do better.

If Carl is on the train, on holiday, gone for months, <your-reason-here> this package becomes unusable for everyone. That's too risky. Pylint-django has 3 maintainers (the pyroma recommended minimum), this is already better. Pylint itself has 6.

How about adding the maintainers of pylint-django also as maintainers to this package? (Sorry, if that's a creepy suggestion.)

@carlio? @atodorov? @colinhowe? Or anyone else volunteering?

@atodorov
Copy link
Contributor

atodorov commented Sep 27, 2019

@bittner +1 on my side, I can help maintain this project too, also push builds to PyPI. All depending on time of course but so far I've managed ;-)

@carlio carlio merged commit 64161a8 into pylint-dev:master Sep 27, 2019
@carlio
Copy link
Member

carlio commented Sep 27, 2019

Version 0.6 is now on PyPI

@atodorov I am happy to add you as a maintainer if you want!

I think @colinhowe hasn't actually done much for pylint-django, not sure if he forgot about it :-)

@colinhowe
Copy link

Hello! Sorry, I've moved city and jobs in the past few months and haven't really had free time for anything apart from decorating the house :) I'm happy to be kept on the list and be a fallback reviewer if things get clogged up.

@michael-k michael-k deleted the import-error branch September 30, 2019 14:08
@lk-jeffpeck
Copy link

Can we get the latest pylint-plugin-utils==0.6 on conda-forge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'UnknownMessageError'

10 participants