Skip to content

Import exception from pylint.exceptions instead of utils #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Import exception from pylint.exceptions instead of utils #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d1bca8
Import exception from pylint.exceptions instead of utils
michael-k Sep 24, 2019
9ecd039
Cleanup import and drop support for pylint < 1.7
michael-k Sep 25, 2019
43e8347
Add minimal required version of pylint to setup.py
michael-k Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pylint_plugin_utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import sys
try:
from pylint.utils import UnknownMessage
except ImportError:
from pylint.utils import UnknownMessageError as UnknownMessage

from pylint.exceptions import UnknownMessageError


def get_class(module_name, kls):
Expand Down Expand Up @@ -137,7 +135,7 @@ def get_message_definitions(message_id_or_symbol):
for pylint_message in pylint_messages
for symbol in (pylint_message.msgid, pylint_message.symbol)
if symbol is not None]
except UnknownMessage:
except UnknownMessageError:
# This can happen due to mismatches of pylint versions and plugin expectations of available messages
symbols = [message_id_or_symbol]

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
author_email='code@landscape.io',
description=_short_description,
version=_version,
install_requires=['pylint'],
install_requires=['pylint>=1.7'],
packages=_packages,
license='GPLv2',
classifiers=_classifiers,
Expand Down