Feat powerful sponge

[balugaq]

Closes #41

[Seggan]

You seem to have turned every range into getRange? Great job otherwise 👍

[LordIdra]

Will need rebasing after the latest round of changes

Couple of issues I've found

• The lore of the sponges isn't in line with the other Pylon items. I'd recommend having a look at the lore of other items to see how we do things and try to make the sponges more in line with that. (For example, usage of colors, and the star icons have a specific use case)
• The new sponges drop vanilla sponges when broken?
• No recipe for hot lava sponge

[balugaq]

Will need rebasing after the latest round of changes

Couple of issues I've found

• The lore of the sponges isn't in line with the other Pylon items. I'd recommend having a look at the lore of other items to see how we do things and try to make the sponges more in line with that. (For example, usage of colors, and the star icons have a specific use case)
• The new sponges drop vanilla sponges when broken?
• No recipe for hot lava sponge

For hot lava sponge recipe:

I'll test other issues if InvUI no longer stop me from gradle build

[LordIdra]

Am I correct in thinking this does not actually need to be split into multiple classes? Surely the behaviour of all the sponges can be unified into one class? I might be wrong though.

[balugaq]

For PowerfulWaterSponge and LavaSponge, yes.
But HotLavaSponge have more mechanism: REUSE_RATE and particles.
Also the WetPowerfulWaterSponge is a placeholder block. It's not a usable sponge in fact.

[LordIdra]

Still have very mixed feelings about this turning either into obsidian or lava sponge. I would suggest we maybe just always turn it into lava sponge? any other thoughts?

[balugaq]

From my prospective, it is too powerful for HotLavaSponge. So turning it into obsidian is a way to limit it.

[LordIdra]

With regards to the ticking conversation, can't we just use SpongeAbsorbEvent via PylonSponge instead of ticking?

I think the better approach here would be to remove the reuse rate mechanic and make the lava sponge reusable as I don't think it's that powerful considering it just deletes lava without giving it to you. If we're concerned about balance we could always lower the radius. This would allow all the sponge classes to be unified, thereby removing a lot of code and simplifying stuff, and would also be a nicer mechanic IMO. @Seggan @OhmV-IR @JustAHuman-xD do any of you have any opinions here?

[OhmV-IR]

Member

+1 agree

[balugaq]

About ticking, I have to use ticking if I need to absorb more than water, something like waterlogged block may won't trigger the event.

[Seggan]

I think the better approach here would be to remove the reuse rate mechanic and make the lava sponge reusable as I don't think it's that powerful considering it just deletes lava without giving it to you. If we're concerned about balance we could always lower the radius. This would allow all the sponge classes to be unified, thereby removing a lot of code and simplifying stuff, and would also be a nicer mechanic IMO. @Seggan @OhmV-IR @JustAHuman-xD do any of you have any opinions here?

I don't really care honestly

[balugaq]

With regards to the ticking conversation, can't we just use SpongeAbsorbEvent via PylonSponge instead of ticking?

In this way, ticker can do all the thing the PylonSponge can do. Should we remove or rewrite PylonSponge?

[LordIdra]

With regards to the ticking conversation, can't we just use SpongeAbsorbEvent via PylonSponge instead of ticking?

In this way, ticker can do all the thing the PylonSponge can do. Should we remove or rewrite PylonSponge?

Gotcha. Happy to keep it as a ticker. I do think we should generify this into one class though as it seems unnecessarily complex right now

[balugaq]

Added AbsorbHandler, now the block transformation should be clearer*

[LordIdra]

Closing for now as we are hoping to do the rename today so this PR will become unmergable, and there are still a lot of things I would like changed here before we merge it. I will open a new PR based off of this one after the rename happens