Open
Conversation
Seggan
reviewed
Mar 10, 2026
Member
Seggan
left a comment
Seggan
left a comment
There was a problem hiding this comment.
Have you seen how we do display-only recipes currently?
Member
Author
Yes, it is a read only file filled with warnings, which is very error prone and bad practice, because it doesnt actually change the underlying hardcoded recipe |
LordIdra
requested changes
Mar 11, 2026
Contributor
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
2 small things here
- it would be nicer to have the purification tower ('x' in the gui) cycle through the purification towers - see the hammer recipe for an example of how to do this, it's really simple
- you can just lazily get the recipes whenever you need to display the gui, yeah it's slower but no one cares as it is being called very rarely, it's nice and simpler than the listener
JustAHuman-xD
requested changes
Mar 18, 2026
src/main/java/io/github/pylonmc/pylon/content/machines/hydraulics/HydraulicPurifier.java
Show resolved
Hide resolved
LordIdra
approved these changes
Mar 18, 2026
Contributor
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Tested, towers are shown in the wrong order but that's probably fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #844