Open
Conversation
Comment on lines
207
to
209
| public @Nullable ItemDisplay getHammerTip() { | ||
| return getHeldEntity(ItemDisplay.class, "hammer_tip"); | ||
| return getHeldEntityOrThrow(ItemDisplay.class, "hammer_tip"); | ||
| } |
Contributor
There was a problem hiding this comment.
no longer nullable, also why the change?
LordIdra
reviewed
Mar 18, 2026
| name: "<white>Flight Ring" | ||
| lore: |- | ||
| <arrow> Allows creative flight | ||
| <arrow> Does not stack |
Contributor
There was a problem hiding this comment.
This does not need 'does not stack' as it isn;'t a talisman - the stacking thing is just meant to clarify that talisman effects do not stack. (I don't know if we want to make that clearer?)
LordIdra
reviewed
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #894
Fixes #766
Fixes #885
Fixes #882
Fixes #813
Fixes #869
Fixes #799