Skip to content

Task killer#903

Open
Intybyte wants to merge 10 commits intomasterfrom
vaan/task/task-killer
Open

Task killer#903
Intybyte wants to merge 10 commits intomasterfrom
vaan/task/task-killer

Conversation

@Intybyte
Copy link
Member

@Intybyte Intybyte commented Mar 17, 2026

Fixes #894
Fixes #766
Fixes #885
Fixes #882
Fixes #813
Fixes #869
Fixes #799

Comment on lines 207 to 209
public @Nullable ItemDisplay getHammerTip() {
return getHeldEntity(ItemDisplay.class, "hammer_tip");
return getHeldEntityOrThrow(ItemDisplay.class, "hammer_tip");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer nullable, also why the change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match diesel one

Copy link
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny thing

name: "<white>Flight Ring"
lore: |-
<arrow> Allows creative flight
<arrow> Does not stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need 'does not stack' as it isn;'t a talisman - the stacking thing is just meant to clarify that talisman effects do not stack. (I don't know if we want to make that clearer?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it kinda is internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants