Skip to content

Task/misc#962

Merged
LordIdra merged 13 commits into
pylonmc:masterfrom
SchnTgaiSpock:task/misc
May 18, 2026
Merged

Task/misc#962
LordIdra merged 13 commits into
pylonmc:masterfrom
SchnTgaiSpock:task/misc

Conversation

@SchnTgaiSpock
Copy link
Copy Markdown
Contributor

@SchnTgaiSpock SchnTgaiSpock commented Apr 20, 2026

Closes #771
Closes #842
Closes #933
Closes #944

Copy link
Copy Markdown
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smelting a steel chestplate does not actually seem to work

Comment thread src/main/resources/lang/en.yml
@SchnTgaiSpock
Copy link
Copy Markdown
Contributor Author

Smelting a steel chestplate does not actually seem to work

whoops didnt realize blasting recipes werent automatically copied to the furnace too lol

on another note i found out they dont smelt if they are damaged at all since its matched with ExactChoice and also f**king mojang wont let me extend RecipeChoice (like whats even the point of using java then)

so i think the only option i have left is to manually listen to presmelt/smelt events? unless someone has a better option

@Seggan
Copy link
Copy Markdown
Member

Seggan commented Apr 22, 2026

The easiest would ofc be to implement an exact match recipe for every single durability but that'd make Pylon load like 100x slower. Idk if its possible with the events, feel free to try.

@JustAHuman-xD
Copy link
Copy Markdown
Contributor

I imagine we could combine approaches event listening w/ recipe handling. Allowing for material choice but it supports ItemTypeWrapper so other components can be ignored

Copy link
Copy Markdown
Contributor

@LordIdra LordIdra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Comment thread src/main/resources/recipes/pylon/grindstone.yml Outdated
Comment thread src/main/resources/recipes/pylon/hammer.yml Outdated
Comment thread src/main/resources/recipes/minecraft/smelting.yml
@SchnTgaiSpock
Copy link
Copy Markdown
Contributor Author

Ready

Comment thread src/main/java/io/github/pylonmc/pylon/PylonItems.java Outdated
@LordIdra LordIdra merged commit 6c11dbe into pylonmc:master May 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants