Skip to content

Conversation

@vnherdeiro
Copy link
Contributor

Prototyping a pymc3 model inside a Jupyter notebook the tqdm progress bars can get ugly or buggy. There is a version of these progress bars tailored for notebooks and addressing these issues. The imports are now aware of the environment and load the appropriate ones.

import tqdm

tqdm_ = tqdm.tqdm
from tqdm.auto import tqdm as tqdm_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably just change tqdm_ below to tqdm, the existing pattern here is pretty weird.

@twiecki
Copy link
Member

twiecki commented Jun 25, 2019

Thanks - this looks great! Also needs a line in the release-notes.

@rpgoldman
Copy link
Contributor

What about squashing this together into one commit before merging? In particular, we don't really need "fixed the tqdm.trange calls" in the history...

Does requirements-dev also need updating?

@twiecki
Copy link
Member

twiecki commented Jun 25, 2019

@rpgoldman We can just squash and merge on github now.

@vnherdeiro vnherdeiro closed this Jun 25, 2019
@vnherdeiro vnherdeiro deleted the tqdm-notebook-feature branch June 25, 2019 16:09
@rpgoldman
Copy link
Contributor

@rpgoldman We can just squash and merge on github now.

Sounds good to go then.

I see that requirements-dev complements requirements, so it does not need an update.

Thanks, @vnherdeiro !

@vnherdeiro
Copy link
Contributor Author

vnherdeiro commented Jun 25, 2019

I am gonna clean the working tree and do a new pull request. A bit brute force, but effective.

edit: done.

@vnherdeiro
Copy link
Contributor Author

Does requirements-dev also need updating?

I do not think so.

@rpgoldman
Copy link
Contributor

@vnherdeiro

Does requirements-dev also need updating?

I do not think so.

You were right about this; I was wrong -- the developer requirements are added to the requirements, so the development environment will be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants