-
Notifications
You must be signed in to change notification settings - Fork 2.2k
tqdm imports now supporting console and notebook modes #3530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/pymc3 into tqdm-notebook-feature
| import tqdm | ||
|
|
||
| tqdm_ = tqdm.tqdm | ||
| from tqdm.auto import tqdm as tqdm_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably just change tqdm_ below to tqdm, the existing pattern here is pretty weird.
|
Thanks - this looks great! Also needs a line in the release-notes. |
|
What about squashing this together into one commit before merging? In particular, we don't really need "fixed the Does |
|
@rpgoldman We can just squash and merge on github now. |
Sounds good to go then. I see that Thanks, @vnherdeiro ! |
|
I am gonna clean the working tree and do a new pull request. A bit brute force, but effective. edit: done. |
I do not think so. |
You were right about this; I was wrong -- the developer requirements are added to the requirements, so the development environment will be correct. |
Prototyping a pymc3 model inside a Jupyter notebook the tqdm progress bars can get ugly or buggy. There is a version of these progress bars tailored for notebooks and addressing these issues. The imports are now aware of the environment and load the appropriate ones.