replaced all imports of tqdm with tqdm.auto #3531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Needs a line in the release notes. Also, can you post a screenshot of what this now looks like for single and parallel sampling? |
Contributor
Author
|
@twiecki Screenshots for single and parallel sampling, respectively:
About the release note: not sure what to add. |
Member
|
Under new features write: `* Make use of new tqdm auto mode which improves progress bars in jupyter notebooks" or something along those lines. |
Contributor
Author
|
Went for:
|
Member
|
@twiecki, I'm going to hit merge, this is small enough that I'm confident it won't break anything 😄 |
Contributor
Author
|
Can I get a PyMC3 laptop sticker for this contribution? ps: shamelessly sorry for bumping this..! |
Member
|
Totally. Send an address to colcarroll at gmail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototyping a pymc3 model inside a Jupyter notebook the tqdm progress bars can get ugly or buggy. There is a version of these progress bars tailored for notebooks and addressing these issues. The imports are now aware of the environment and load the appropriate ones.