Check load_trace argument #3534
Conversation
|
@ColCarroll One piece of advice I could use is what |
rpgoldman
force-pushed
the
check-load-trace
branch
from
74f0cce to
783c4a7
Compare
I suppose |
ColCarroll
left a comment
ColCarroll
left a comment
There was a problem hiding this comment.
Looks good -- one nitpick, plus I agree that ValueError or a custom error (that inherits from ValueError) is a better idea.
pymc3/backends/ndarray.py
Outdated
There was a problem hiding this comment.
should be if len(straces) == 0 (or if not straces), since testing list equality is dangerous
There was a problem hiding this comment.
Thanks. Everything should be in place now. ISTR getting a pylint complaint about checking length as a way to check for an empty list, so I went for if not straces.
Add new exception class. While doing this, added type annotations to ndarray.py
rpgoldman
force-pushed
the
check-load-trace
branch
from
783c4a7 to
bf05b41
Compare
| class IncorrectArgumentsError(ValueError): | ||
| pass | ||
|
|
||
| class TraceDirectoryError(ValueError): |
There was a problem hiding this comment.
nice. i did not know this file existed!
|
I'll merge once tests pass -- thanks! |
pymc3/backends/ndarray.py
Outdated
| self._stats = [] | ||
| for sampler in sampler_vars: | ||
| data = dict() | ||
| data: Dict[str, np.ndarray] = dict() |
There was a problem hiding this comment.
sorry, this line is too current for python 3.5...
There was a problem hiding this comment.
Oh, crumbs. I keep forgetting. I'll replace that with the corresponding type comment. My bad.
This commit should be squashed before merging...
2 participants
Still needs a test. But comments welcome.