MLX Elementwise and scalar dispatches#2007
Merged
Merged
Conversation
f21ea8a to
a2aa2f3
Compare
ricardoV94
reviewed
Mar 29, 2026
ricardoV94
approved these changes
Mar 29, 2026
6cf194c to
d730255
Compare
jessegrabowski
commented
Mar 29, 2026
|
|
||
| @mlx_funcify.register(Composite) | ||
| def mlx_funcify_Composite(op, node=None, **kwargs): | ||
| return mlx_funcify(op.fgraph, squeeze_output=True) |
Member
Author
There was a problem hiding this comment.
In jax OpFromGraph dispatch we're calling the jax rewrites on the inner graph, but not in Composite. I followed that lead, but it seems inconsistent
Member
There was a problem hiding this comment.
Composite is never optimized internally, it's supposed to already be a good graph. OpFromGraph and Scan are, but we should actually explicitly optimize as a rewrite, not at compile/runtime. We are working towards that... but it takes time
Which is why I want to make their inner graphs frozen as well
d730255 to
31d747a
Compare
31d747a to
8fcf847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some simple/boring stuff for the MLX backend:
nfunc_nameto look in themxnamespace and get everything we can. There's a dictionary of overrides for stuff that doesn't follow the array standard (invertisbitwise_invertandtrue_divideisdivideRelated Issue
Checklist
Type of change