Add MLX dispatch for IfElse#2013
Merged
Merged
Conversation
ricardoV94
approved these changes
Mar 29, 2026
Member
|
have an xpass strict |
aaefabd to
6f49ceb
Compare
Member
Author
|
I also snuck a dispatch for TypeCastingOp (it's an identity function) so I split it into a separate commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no support for conditional logic in MLX, so the best we can do is
mx.where. It ends up being similar to the limitations in jax --jax.lax.condgets rewritten tojax.lax.select, which is also wherejnp.whereends up if you pass all 3 inputs (which we do in this case).So IfElse sucks again -- it will evaluate both branches. But I submit that it's better than nothing.