Update Eigh and Eigvalsh Ops#2059
Merged
Merged
Conversation
jessegrabowski
added
enhancement
jessegrabowski
force-pushed
the
eigh-modernization
branch
from
7f465d5 to
e70750f
Compare
Member
Author
|
Tests will fail until #2054 is merged. |
ricardoV94
reviewed
Apr 19, 2026
jessegrabowski
force-pushed
the
eigh-modernization
branch
from
e5c36cb to
ff23e8e
Compare
jessegrabowski
force-pushed
the
eigh-modernization
branch
from
ff23e8e to
35872b6
Compare
ricardoV94
reviewed
Apr 20, 2026
Member
Author
|
Can't reproduce the test failure on my mac, i think there's some lapack difference thing going on. Will keep trying. |
Member
|
try to nuke the cache |
jessegrabowski
force-pushed
the
eigh-modernization
branch
from
be429ba to
6f0c63f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another in my "decompositions nobody asked for" series. Actually this one is useful, eigh/eigvalsh get used here and there in logp of multivariate normal, see here for example. Now the generalized problem I have no idea :) But I was sick of looking at the separate Grad ops that were doing nothing special at all.