Support single string dims in XTensorType#2129
Merged
ricardoV94 merged 1 commit intoMay 13, 2026
Merged
Conversation
ricardoV94
reviewed
May 13, 2026
williambdean
force-pushed
the
support-string-dims-as-xtensor
branch
from
cd1c931 to
231d1b8
Compare
Contributor
Author
|
Jobs seem to be failing due to GitHub ... will have to retrigger . EDIT: Passing. |
ricardoV94
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XTensorType.__init__now normalizes a bare stringdimsto a single-element tuple, preventing unintended character iterationCloses #1793