Check None shape by type not identity in numba SpecifyShape dispatch#2191
Merged
jessegrabowski merged 1 commit intoMay 30, 2026
Merged
Conversation
ricardoV94
approved these changes
May 30, 2026
Member
ricardoV94
left a comment
ricardoV94
left a comment
There was a problem hiding this comment.
This is better but why did it fail without it?
Member
Author
|
NoneConst is just a variable we make. Rebuilding it results in a new object because pickle doesn't carry module-level globals along for the ride. You already recognized this as a problem and cut over most things here, so this just seems like a case that got missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2188