Fixed byte count position for CommEventLogResponse #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_rtu_byte_count_pos for GetCommEventLogResponse is incorrect. This causes incorrect parsing of such responses from RTU slaves / servers.
For reference, a valid RTU response to this command, generated from hardware but using firmware I've written, looks like :
0x5 0xc 0x9 0x0 0x0 0x0 0x0 0x0 0x3 0x80 0x42 0x80 0xb7 0xdd
(With a slave address of 0x5)
As an aside, though this PR does not address the problem, the exception produced is greatly misleading due to the 'Process incoming packets irrespective error condition' approach, which results in the ModbusClient attempting to parse the response using the slave address (unit) as the function code. This can be avoided by atleast stripping the prefix characters from the command (self._hsize) in the event of an error.