Add pressure names for SBE .cnv files#81
Merged
ocefpaf merged 4 commits intopyoceans:masterfrom May 28, 2020
Merged
Conversation
Author
|
Travis-ci failed to build my merge. Log shows that problem is not related to the new commit. It is due to recent changes in matplotlib. |
vonopr
commented
May 27, 2020
Author
vonopr
left a comment
vonopr
left a comment
There was a problem hiding this comment.
Coding artifacts of the previous commit were cleaned.
ocefpaf
reviewed
May 27, 2020
| key_set = False | ||
| prkeys = ["prDM", "prdM", "pr"] | ||
| prkeys = [ | ||
| "prM ", "prE", "prDM", "pr50M", "pr50M1", "prSM", "prdM", "pr" |
Member
There was a problem hiding this comment.
Can you add a comment on the top mentioned that these are the valid names for the seabird CNV format. If you have a link for that info please add that too.
ocefpaf
reviewed
May 27, 2020
ocefpaf
reviewed
May 27, 2020
|
|
||
|
|
||
| def from_cnv(fname): | ||
| def from_cnv(fname, prname=None): |
ocefpaf
force-pushed
the
cnv_pressure
branch
2 times, most recently
from
cd8ffff to
13a1f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for following pressure names: prM, prE, pr50M, pr50M1, prSM.
Closes #80