Fix duplicate best_compatible_tag_index call #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
reviewed
Sep 12, 2025
micropip/transaction.py
Outdated
Comment on lines
416
to
419
| tag_index = wheel._best_tag_index | ||
| if tag_index is None: | ||
| tag_index = best_compatible_tag_index(wheel.tags) | ||
| wheel._best_tag_index = tag_index |
Member
There was a problem hiding this comment.
I think it is not a good idea to update the the private attribute of an object outside.
Instead, we can create a property in WheelInfo object such as
@property
def best_tag_index(self) -> float:
if self._best_tag_index:
return self._best_tag_index
self._best_tag_index = best_compatible_tag_index(self.tags)
return self._best_tag_index
micropip/package_index.py
Outdated
Comment on lines
154
to
161
| try: | ||
| tags = parse_tags(filename) | ||
| except (InvalidVersion, InvalidWheelFilename): | ||
| continue | ||
|
|
||
| tag_index = best_compatible_tag_index(tags) | ||
| if tag_index is None: | ||
| continue |
Member
There was a problem hiding this comment.
Well, is_package_compatible does more than this.
I think we can keep the is_package_compatible call here, and update the signature of is_package_compatible to return the compatible tag as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This computes tag index once, then stash it to wheel._best_tag_index.
Closes #160.