MAINT Remove remaining codes that import compat functions directly#263
Merged
ryanking13 merged 2 commits intopyodide:mainfrom Mar 31, 2026
Merged
MAINT Remove remaining codes that import compat functions directly#263ryanking13 merged 2 commits intopyodide:mainfrom
ryanking13 merged 2 commits intopyodide:mainfrom
Conversation
Member
|
Oops, I totally missed your request for review here, @ryanking13. Please feel free to ping me on Discord at any time, always, if this happens again! |
Member
Author
No worries. I also totally forgot about this PR 😅 As I am preparing for next Pyodide release, I was cleaning up some stale PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step toward #237
This PR removes the all the remaining code that imports function directly from compatibility layer package. instead all the compatibiilty codes are injected as a parameter or a class attribute.
After this, we can clean up the
_compat_not_in_pyodide.pyfrom the micropip package wheel as they are not used in runtime at all.The code structure is not ideal as we inject compat layer everywhere... but I think we can fix that later.