Skip to content

Conversation

@agriyakhetarpal
Copy link
Member

Description

As suggested in #5321 (comment), to fix failing builds for PyO3.

Checklists

N/A

@hoodmane hoodmane added this to the 0.27.1 milestone Jan 13, 2025
Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoodmane
Copy link
Member

Uh oh, the pin didn't work it still downloaded pyo3-0.23.4

@ryanking13
Copy link
Member

ryanking13 commented Jan 14, 2025

Probably we need pyodide/pyodide-build#49 (comment)?

Otherwise, we can set PIP_CONSTAINT env variable globally in CI.

I think the latter is the better option, as pyodide/pyodide-build#49 only applies to in-tree build.

@hoodmane
Copy link
Member

Can you make a PR to fix it @ryanking13?

@hoodmane
Copy link
Member

hoodmane commented Jan 14, 2025

Or maybe we should stop being obstinate and just bump the rust version...

@ryanking13
Copy link
Member

Can you make a PR to fix it @ryanking13?

Sure, let me try.

@hoodmane
Copy link
Member

Thanks!

@ryanking13
Copy link
Member

Oh, I just realized that pyo3 is not a Python package, but it is a rust package 😅. Anyway, let me try to fix this.

@ryanking13
Copy link
Member

I think this will work (tested locally) #5325.

We are using the same approach for cbor-diag

@agriyakhetarpal
Copy link
Member Author

Yes, that looks like a better solution. Thanks, @ryanking13!

@agriyakhetarpal agriyakhetarpal deleted the pin/pyo3 branch January 14, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants