Make JsProxy of object with asyncDispose into async context manager#6014
Merged
hoodmane merged 3 commits intopyodide:mainfrom Dec 1, 2025
Merged
Make JsProxy of object with asyncDispose into async context manager#6014hoodmane merged 3 commits intopyodide:mainfrom
asyncDispose into async context manager#6014hoodmane merged 3 commits intopyodide:mainfrom
Conversation
hoodmane
force-pushed
the
js-async-context-manager
branch
from
1de914f to
e1c1051
Compare
ryanking13
approved these changes
Dec 1, 2025
Member
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Thanks! I left some minor comments, otherwise looks good to me
src/tests/test_jsproxy.py
Outdated
| assert o.closed | ||
|
|
||
|
|
||
| @pytest.mark.xfail_browsers(safari="Symbol.dispose not supported in Safari") |
Member
There was a problem hiding this comment.
Suggested change
| @pytest.mark.xfail_browsers(safari="Symbol.dispose not supported in Safari") | |
| @pytest.mark.xfail_browsers(safari="Symbol.asyncDispose not supported in Safari") |
Drranny
pushed a commit
to Drranny/pyodide
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.