Errors when parsing some valid ISO8601 datetimes

[aaronzen]

The iso8601 conversion fails currently on dates with hour or minute values of 0, if TZ data is present.

For example:

from pyswagger import utils
>>> utils.from_iso8601("2016-06-21T14:02:57Z")
datetime.datetime(2016, 6, 21, 14, 2, 57, tzinfo=<pyswagger.utils.FixedTZ object at 0x1070de910>)
>>> utils.from_iso8601("2016-06-21T00:02:57Z")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/site-packages/pyswagger/utils.py", line 171, in from_iso8601
    raise ValueError('missing h:m when tzinfo is provided: [{0}]'.format(s))
ValueError: missing h:m when tzinfo is provided: [2016-06-21T00:02:57Z]

The issue is in 'pyswagger/utils.py', there is a boolean evaluation of hour/minute and since '0' is falsey the check fails. I believe the intention was to just test for None. The following change resolves the issue:

     if tz_s:
-        if not (hour and minute):
+        if hour == None or minute == None:
             raise ValueError('missing h:m when tzinfo is provided: [{0}]'.format(s))

[mission-liao]

Thanks for pointing out, I'll check this issue this weekend and update my follow-ups at this comment.

It's an obvious bug by misuse the 'if not' in python, I'll fix this bug and provide a new build later

[aaronzen]

Thanks for the quick response!
On Jul 1, 2016 4:12 AM, "mission.liao" notifications@github.com wrote:

Thanks for pointing out, I'll check this issue this weekend.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ARrRd4y4k1jykScqOabDFNhsziy4xQ5Kks5qRMwCgaJpZM4JCyl2
.