Fix _has_valid_outer_pip when pip is missing#1003
Merged
Conversation
notatallshaw
requested review from
FFY00,
gaborbernat,
henryiii and
layday
as code owners
notatallshaw
force-pushed
the
fix-missing-pip-detection
branch
from
a2b38a3 to
bb3b933
Compare
notatallshaw
force-pushed
the
fix-missing-pip-detection
branch
from
bb3b933 to
d7b4dec
Compare
henryiii
approved these changes
Mar 25, 2026
Closed
adamtheturtle
added a commit
to adamtheturtle/literalizer
that referenced
this pull request
Mar 25, 2026
build 1.4.1 has a regression where `_has_valid_outer_pip` returns `True` when pip is not installed, causing isolated build environments to fail with "No module named pip". A fix exists upstream (pypa/build#1003) but has not been released. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
pfebrer
added a commit
to metatensor/metatrain
that referenced
this pull request
Mar 25, 2026
Our CI is failing because of pypa/build#1003 , so we restrict `build` until this is fixed in a release.
Krishnachaitanyakc
added a commit
to Krishnachaitanyakc/Pillow
that referenced
this pull request
Mar 25, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#980 inverted the control flow of
_has_valid_outer_pipto use a walrus operator, but the finalreturn Truewas not updated. When pip is missing,_has_dependencyreturnsNone, theif dist :=block is skipped, and the method returnsTrueinstead ofNone.This causes
buildto try using a non-existent pip via--pythoninstead of falling back to virtualenv.