docs: reorganize testing docs for copy/paste#1043
Conversation
That makes it easier to scan and use as a reference.
gaborbernat
left a comment
There was a problem hiding this comment.
I disagree with removing existing information. I understand that I would prefer if we extended it, not clean it up. Your addition here should be strictly additive.
|
@gaborbernat I think I was careful enough to compress info. but not remove. I removed explanation like ``--only-integration` means only integration tests are run", because it is logical if not obvious. And merged examples directly into text that previously explained it. Actually I needed only copy/pasteable examples on one page to quickly fix tests while I have time. So feel free to format how do you see fit as long as the code blocks are here. The PR allows edits for maintainers, so we should not spend too much time here. By the way, did you use any AI to make #988 ? It is pretty awesome piece of change that I would personally find trouble doing by hand. But I still haven't figure out how to run agents securely. |
|
What do you mean by "securely? If you mean access to things on your computer, then you can run in a container (I haven't done that yet, just been manually okaying operations), or GitHub's got various mechanisms to run agents (see copilot-instructions.yml, or codespaces). For private code, then I think you'd need to run locally; I don't really do much that's not open source, so not something I've had to worry about yet. I've been playing with Qwen 3.6 locally and have had issue with it mis-formatting tool calls and paths. (It's pretty smart, it just randomly loses characters; it usually iterates and fixes it, but it's really annoying and makes it take 3x longer). I'm thinking it might be an issue with a small model + OpenCode's 10K token preamble, I'm tempted to try Pi instead, which has a 1K preamble. I also have access to Kimi-K2.5 on nrp.ai, which is really nice (open weight!), but not small enough to run locally. I'm planning on trying Gemma 4 soon. Kimi-K2.5 feels pretty close to GitHub Copilot + claude-haiku-4.5, maybe even a bit above it. (I think that particular PR looked like it was assisted by Claude Code, at a guess) |
|
To me, it looks pretty similar in content, with just some lost text for the introduction that should be pretty easy to simply put back in. |
|
I've heard some scary stories about agents following rogue instructions while doing lookups on the internet, and sending out private keys and other sensitive data. Also masking instructions with Unicode symbols to make them invisible. Also the statements like that Aider code is 80% written by AI, and also projects like |
Restored the key missing information from the original. The changes merged back into the new code-block layout: - **Opening paragraph**: "Due to its nature, ``build`` has a somewhat complex test suite..." (was simplified to just "``build`` has with two sets of tests...") - **What integration tests do**: "as a sanity check" and "not very helpful for tracking down issues" - **What `--only-integration` does**: "where the latter will disable unit tests and only run integration tests" - **Environment matrix description**: "The project has a fairly large environment matrix..." (was shortened to just "The test matrix covers...") - **Extra environments**: "Additionally, there are environments for type checking and documentation building, plus extras like checking code with minimum versions of dependencies." (was lost) - **`py39-wheel` example**: "You can also run unit tests against a specific Python version with wheel installation using `tox -e py39-wheel`." (was lost) - **Coverage paragraph**: Restored "Code coverage is tracked to ensure all code paths are tested. Aim for complete coverage..." (was shortened to "Test generate code coverage, so try to get complete coverage...") Assisted-by: OpenCode:Kimi-K2.5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
|
I've used Kimi-K2.6 to restore missing information while keeping the original structure intact (that was basically my prompt!). Maybe that's better? Might be okay to trim a bit. |
layday
left a comment
There was a problem hiding this comment.
I agree with the general sentiment that the docs are too verbose and visually indistinct. A few suggestions below.
Co-authored-by: layday <layday@protonmail.com>
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Description
Make it easier to scan and copy/paste the needed command. I forgot how to run tests, and my reading skills were all time low today.
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)