tests: keep environment from leaking in Python 3.15#1049
Conversation
ff04f6d to
5e4e16e
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
5e4e16e to
9ab2ac0
Compare
|
@copilot investigate the CI failure. |
Agent-Logs-Url: https://github.com/pypa/build/sessions/529b021b-454c-4c33-98b2-6a10516e0cf5 Co-authored-by: henryiii <4616906+henryiii@users.noreply.github.com>
The CI failure was a coverage failure: Root cause: Python 3.15 uses Fix (commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
I feel both of these tests are too generic to be meaningful. What are we testing, that a venv is a venv? |
|
I can probably combine the tests. The first one is the original one, with the added protection from #1047. The second is the same test but with an injected PYTHONPATH to verify it fails regardless of the external PYTHONPATH setting - but I think we could just add that to the first test. |
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
053b394 to
36db83a
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
|
I believe this issue wouldn't show up if we just checked |
|
The issue only exists in the test. Whether we guard against PYTHONPATH in this one test or not has no impact on the actual running of the tool, so I don’t think it matters much either way. |
|
It shows that we need to guard it in the code itself (yes, this is way too unit-testy of a unit-test, testing the internals by mimicking the internals instead of using them!) If we want to drop the test or change it, I think that should be a followup. This only fixes the current test to work on 3.15, and adds 3.15 to our CI. |
Description
Fix #1047.
🤖 Use a bit of copilot with both gpt-5-mini and Kimi-K2.6, mostly to automate running and appying the example. Hand wrote most of the config changes and some of the code changes.
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)