ci: fix broken tests#436
Conversation
999a477 to
92dbe26
Compare
92dbe26 to
9bef490
Compare
|
The main issue with most of the failures is |
|
I believe all PyPy problems are due to a single bug, and that bug is getting fixed in https://foss.heptapod.net/pypy/pypy/-/issues/3323 for PyPy 7.3.9, which is planned to be released in a couple of weeks or so. I'll try to test with with a nightly build in a few days if possible. For now, I'm thinking we can xfail |
5901c79 to
58ba483
Compare
58ba483 to
6438f9d
Compare
6438f9d to
f0eaa3a
Compare
FFY00
left a comment
There was a problem hiding this comment.
Thank you so much for looking into this!
I'll try to test with with a nightly build in a few days if possible.
If it fixes it, we should update the code. We can do that later.
| test | ||
| commands = | ||
| pytest -rsx --cov --cov-config pyproject.toml \ | ||
| pytest -ra --cov --cov-config pyproject.toml \ |
There was a problem hiding this comment.
It summarizes (s)skips, (x)fails, and failures (f, perhaps?). That way you can read a quick summary of everything at the end (like the failures I posted above). Otherwise, you can't easily see what failed, only what was skipped or xfailed! (There's also "A", IIRC, which prints passes too, which is silly for a summary, but failures are important).
FYI, the default is to show failures, but manually specifying it requires an explicit "f", or in this case, "a". I always use "a".
There was a problem hiding this comment.
Right, that's the value of -r. I would've separated them with a space for clarity, otherwise it looks like you're chaining multiple flags.
We have to do that later, I'm quite sure this morning's fix is not in the nightlies yet. :D |
WIP at the moment. These are the 11 Windows PyPy failures: