Skip to content

ci: fix broken tests#436

Merged
FFY00 merged 3 commits into
pypa:mainfrom
henryiii:henryiii/ci/testfix
Feb 25, 2022
Merged

ci: fix broken tests#436
FFY00 merged 3 commits into
pypa:mainfrom
henryiii:henryiii/ci/testfix

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

@henryiii henryiii commented Feb 4, 2022

WIP at the moment. These are the 11 Windows PyPy failures:

FAILED tests/test_env.py::test_isolated_env_log - subprocess.CalledProcessErr...
FAILED tests/test_main.py::test_build_package - subprocess.CalledProcessError...
FAILED tests/test_main.py::test_build_package_via_sdist - subprocess.CalledPr...
FAILED tests/test_main.py::test_build_package_via_sdist_cant_build - subproce...
FAILED tests/test_main.py::test_output[via-sdist-isolation] - SystemExit: 1
FAILED tests/test_main.py::test_output[wheel-direct-isolation] - SystemExit: 1
FAILED tests/test_util.py::test_wheel_metadata[True] - subprocess.CalledProce...
FAILED tests/test_util.py::test_wheel_metadata_isolation - subprocess.CalledP...
FAILED tests/test_util.py::test_with_get_requires - subprocess.CalledProcessE...
FAILED tests/test_main.py::test_output_env_subprocess_error[no-color] - asser...
FAILED tests/test_main.py::test_output_env_subprocess_error[color] - assert [...

@henryiii
Copy link
Copy Markdown
Contributor Author

The main issue with most of the failures is python -IM ensure-up --upgrade --default-pip is failing with no module named encodings. Our error reporting still needs work, as that error is completely hidden.

@henryiii
Copy link
Copy Markdown
Contributor Author

henryiii commented Feb 25, 2022

I believe all PyPy problems are due to a single bug, and that bug is getting fixed in https://foss.heptapod.net/pypy/pypy/-/issues/3323 for PyPy 7.3.9, which is planned to be released in a couple of weeks or so. I'll try to test with with a nightly build in a few days if possible. For now, I'm thinking we can xfail strict these tests, and then remove the workarounds once the new PyPy hits.

@henryiii henryiii force-pushed the henryiii/ci/testfix branch 5 times, most recently from 5901c79 to 58ba483 Compare February 25, 2022 17:08
@henryiii henryiii force-pushed the henryiii/ci/testfix branch from 58ba483 to 6438f9d Compare February 25, 2022 17:34
@henryiii henryiii force-pushed the henryiii/ci/testfix branch from 6438f9d to f0eaa3a Compare February 25, 2022 17:51
@henryiii henryiii marked this pull request as ready for review February 25, 2022 19:03
Copy link
Copy Markdown
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for looking into this!

I'll try to test with with a nightly build in a few days if possible.

If it fixes it, we should update the code. We can do that later.

@FFY00 FFY00 merged commit 59a3f3d into pypa:main Feb 25, 2022
Comment thread tox.ini
test
commands =
pytest -rsx --cov --cov-config pyproject.toml \
pytest -ra --cov --cov-config pyproject.toml \
Copy link
Copy Markdown
Member

@layday layday Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does -a do?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It summarizes (s)skips, (x)fails, and failures (f, perhaps?). That way you can read a quick summary of everything at the end (like the failures I posted above). Otherwise, you can't easily see what failed, only what was skipped or xfailed! (There's also "A", IIRC, which prints passes too, which is silly for a summary, but failures are important).

FYI, the default is to show failures, but manually specifying it requires an explicit "f", or in this case, "a". I always use "a".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's the value of -r. I would've separated them with a space for clarity, otherwise it looks like you're chaining multiple flags.

@henryiii henryiii deleted the henryiii/ci/testfix branch February 25, 2022 19:14
@henryiii
Copy link
Copy Markdown
Contributor Author

We can do that later.

We have to do that later, I'm quite sure this morning's fix is not in the nightlies yet. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants