Clarify default file selection for wheels#1015
Merged
Merged
Conversation
The sentence was previously ambiguous and wasn't clear whether the "Python" adjective referred to the "file" noun as well. In fact all non-.py files are included, so reword slightly to better clarify.
ofek
approved these changes
Oct 26, 2023
Contributor
ofek
left a comment
ofek
left a comment
There was a problem hiding this comment.
Thanks! FYI based on feedback I will change this fallback to actually produce an error instead. What do you think about that?
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
The sentence was previously ambiguous and wasn't clear whether the "Python" adjective referred to the "file" noun as well. In fact all non-.py files are included, so reword slightly to better clarify. 3859562
Contributor
Author
|
@ofek I think the current behavior is preferabl because this way hatch matches the behavior of pdm and poetry -- they include all files within python package dirs by default. Also this is what setuptools now defaults to as long as you're using pyproject.toml and have setuptools-scm installed. |
ofek
added a commit
that referenced
this pull request
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentence was previously ambiguous and wasn't clear whether the "Python" adjective referred to the "file" noun as well.
In fact all non-.py files are included, so reword slightly to better clarify.