Skip to content

Refactor validate_record#167

Merged
pradyunsg merged 3 commits into
pypa:mainfrom
BlueGlassBlock:issue156
Mar 2, 2023
Merged

Refactor validate_record#167
pradyunsg merged 3 commits into
pypa:mainfrom
BlueGlassBlock:issue156

Conversation

@BlueGlassBlock
Copy link
Copy Markdown
Contributor

@BlueGlassBlock BlueGlassBlock commented Mar 2, 2023

Address #156

  • Moved tests to TestWheelFile
  • rename the argument to validate_contents, and make it kw-only.
  • should validate that everything has a hash/size even if validate_contents is False.
  • should validate that RECORD signatures are not mentioned in the RECORD.
  • should validate that the RECORD file is mentioned without hash or size.
  • documentation needs to present an example and add cross-references to/from WheelSource.validation_error.

@BlueGlassBlock BlueGlassBlock changed the title Refactor validate_record Refactor validate_record Mar 2, 2023
@pradyunsg
Copy link
Copy Markdown
Member

Thanks for filing this @BlueGlassBlock! I'll merge this since this gets us most of the way there and we can tackle the docs in a follow up! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants