WIP record parser

[uranusjr]

Let’s get something started? :p

First posted to make sure I’m on the right track. I’ll rewrite this to be Python 2.7 compatible if this approach looks valid. Already did.

[gaborbernat]

I would personally not put the record parsing within the wheels module, but rather a package 👍

[uranusjr]

Any suggestion on the module/package name? I need somewhere to put the parser, and wheels.py is rather arbitrary. Another idea is records.py which can also contain the RECORD writer.

[gaborbernat]

I agree on records.py that's part of a package installer. Generally, the installer will only understand wheels so I don't think it makes sense to add a wheels package.

[uranusjr]

Heh, isort and black are refusing to work together.

[brettcannon]

@uranusjr we get semi-regular issues from isort and Black users on the Python extension for VS Code from complaining about them competing with each other. 😆

[gaborbernat]

Did we set up the configuration to match the style? If so should be just one issue (when there's a comment for an import)?

[pradyunsg]

Suggested change

	try: # pragma: no cover
	from typing import TYPE_CHECKING
	except ImportError: # pragma: no cover
	TYPE_CHECKING = False
	if False:
	from typing import TYPE_CHECKING
	else:
	TYPE_CHECKING = False # type: ignore

nit: let's not import typing even on Python 2 (to avoid uninstalling-in-use-module issues if pip vendors this)?

[uranusjr]

In that case, why not just TYPE_CHECKING = False?

[pradyunsg]

To make mypy/typing/pytype actually treat this value as "ALWAYS FALSE", which is different from a False assignment.

[pradyunsg]

:/

Don't merge PRs with a WIP in the heading? I never got the chance to respond to comments I made, or review this PR.

[gaborbernat]

I thought draft PRs are for that 🤔

[pradyunsg]

I agree that draft PRs also indicate this in a much better way. However, the title clearly says "WIP" (it still does) which is a fairly non-ambiguously indicates the same thing.

If y'all reckon PRs are OK to merge while "WIP" is the first thing in their titles, I disagree with that. Anyway, it was very surprising that a PR with WIP in it's title got merged, and I was certainly caught off guard by that.

I don't really have much to say other than, well, I was caught off guard.