Introduce more Ruff rules #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
force-pushed
the
more-ruff-rules
branch
from
04c6f79 to
6ce1114
Compare
Closed
Secrus
force-pushed
the
more-ruff-rules
branch
2 times, most recently
from
beb0492 to
e1a740c
Compare
Secrus
commented
Aug 30, 2024
Secrus
commented
Aug 30, 2024
Secrus
commented
Aug 30, 2024
Merged
pradyunsg
approved these changes
Nov 1, 2024
Member
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
LGTM, barring one non-blocking concern.
Secrus
force-pushed
the
more-ruff-rules
branch
from
e1a740c to
627d6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.