Apply repo-review rules #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
reviewed
Sep 25, 2024
RF003: src directory doesn't need to be specified anymore (0.6+)
Ruff now (0.6+) looks in the src directory by default.
The src setting doesn't need to be specified if it's just
set to `["src"]`.
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
c8822cb to
2edc448
Compare
https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules Also enable flake8-implicit-str-concat (ISC) rules, they are quite useful. Unfortunately, ISC001 and ISC002 are not fully compatible with the formatter. Run them manually from time to time...
MY103: MyPy warn unreachable
Must have `warn_unreachable` (true/false) to pass this check.
Follow the style of the pre-commit doc itself: https://pre-commit.com/#2-add-a-pre-commit-configuration
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
2edc448 to
3d47afb
Compare
Secrus
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.scientific-python.org/development/guides/repo-review/?repo=pypa%2Finstaller&branch=main
Rules
RF101andRF103will be enforced by #230.