perf: use os.path.abspath() instead of Path.resolve()#326
Merged
Conversation
Additionally, remove the Windows long path workaround because it should not be required if we no not resolve paths.
pradyunsg
approved these changes
Apr 6, 2026
Secrus
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a significant performance regression due to #317. The time to install a sample project with some dependencies increased from 8 seconds (Poetry 2.3.2) to 13 seconds (Poetry 2.3.3). (Poetry applies the same fix.)
This can be fixed by using
os.path.abspath()instead ofPath.resolve().This should be safe. At least, I could not craft a wheel that triggers a path traversal via symlinks. Also see the unit test in python-poetry/poetry#10821. Further,
os.path.abspath()is recommended in https://docs.python.org/3/library/zipfile.html#zipfile.Path and (if I do not miss anything) pip also usesos.path.abspath()(and notPath.resolve()): https://github.com/pypa/pip/blob/8c5468dc9695c023c0a6428e630126aa14c9db4e/src/pip/_internal/utils/unpacking.py#L79-L87Additionally, remove the Windows long path workaround because it should not be required if we no not resolve paths.