installer: add --interpreter option#332
Closed
rossburton wants to merge 1 commit into
Closed
Conversation
The currently running Python might not be the right one for the installed wheels, so add an option to allow the interpreter to be overridden. This is essential in cross/distro builds where we want to install a wheel into a working directory to build a distro package (eg a rpm or deb) with pypa/installer, but the currently running python on the build host might not be the right path for the scripts to use on the target.
Member
Author
|
I'd actually forgotten that I'd been here before in #107. Does your position still stand that everyone who is currently patching these few lines in need to continue patching forever? The previous statement was basically just write your own installer tool that is 99% identical to pypa/installer but with one extra option, which seems like pointless duplication. Especially as at the time the argument was "the API supports that", but #175 merging absolutely means that it would not anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently running Python might not be the right one for the installed wheels, so add an option to allow the interpreter to be overridden.
This is essential in cross/distro builds where we want to install a wheel into a working directory to build a distro package (eg a rpm or deb) with pypa/installer, but the currently running python on the build host might not be the right path for the scripts to use on the target.