Refactor path handling to use pathlib.

[jameshilliard]

This should help reduce the amount of special casing needed for windows paths.

[pradyunsg]

Thanks for filing this!

I don't think there's much Windows-related special casing in this codebase and, overall, I think the code style that this PR introduces adds more complexity than it adds value in terms of clarity or ease of use. I'm going to close this, to reflect that I don't think this conversion is worthwhile.

[jameshilliard]

I don't think there's much Windows-related special casing in this codebase and, overall, I think the code style that this PR introduces adds more complexity than it adds value in terms of clarity or ease of use.

I guess the main issue is that using os.path makes it rather difficult to reason about correctness since it's otherwise unclear what type of path(unix vs os style) the various codepaths actually expect to get passed. Is there a better way to make the path type demarcations clearer?

Isn't os.path generally not recommended to be used in favor of pathlib these days in general?