feat: install yasm on all x86_64 variants #1861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi!
seeing how quickly I could get someone to add
git-lfs, I have another proposal:Currently,
yasminexplicably only exists in the final images formanylinux2014and RHEL-like images, e.g. the almalinux-basedmanylinux_2_28(the cibuildwheel default for manylinux)Other images like the alpine-based
musllinux_1_2(the cibuildwheel default for musllinux) don't have it, and I'm not sure if that is intentional.The goal here is to a) get a consistent set of tools between variants (or at least coincidentally work towards that) and b) because some projects need yasm/nasm to compile, e.g. ffmpeg. Since some images already had yasm, I figured it should be fine to include it in all of them.
Helpful links: cibuildwheel's default image versions and more importantly the default image variants
I let this build on github actions in my fork and only two matrix branches failed, neither of which should even be changed by my PR:
The errors look unrelated to my change and only seem to happen on "funky" architectures, maybe that's normal