Skip to content

Make translation strings collection workflow use a dedicated branch#1014

Merged
webknjaz merged 8 commits intopypa:mainfrom
webknjaz:maintenance/gha-i18n-pot
Dec 4, 2021
Merged

Make translation strings collection workflow use a dedicated branch#1014
webknjaz merged 8 commits intopypa:mainfrom
webknjaz:maintenance/gha-i18n-pot

Conversation

@webknjaz
Copy link
Copy Markdown
Member

No description provided.

@webknjaz webknjaz added type: bug A confirmed bug or unintended behavior type: enhancement A self-contained enhancement or new feature labels Nov 27, 2021
@webknjaz webknjaz enabled auto-merge November 27, 2021 18:09
@webknjaz
Copy link
Copy Markdown
Member Author

This should help us keep Weblate source strings up-to-date, finally.

@webknjaz webknjaz marked this pull request as draft November 27, 2021 18:38
auto-merge was automatically disabled November 27, 2021 18:38

Pull request was converted to draft

Comment thread .github/workflows/translation.yml Outdated
@rffontenelle
Copy link
Copy Markdown
Contributor

rffontenelle commented Nov 29, 2021

@webknjaz you said it is not working on Weblate. Not sure what's up, but have you considered setting on Weblate the input POT to the new branch?

TBH I don't know if you can set separate branches for POT and PO. If you can't, you might want to consider a different repository for translations. See https://docs.weblate.org/en/latest/faq.html#how-can-i-limit-weblate-access-to-only-translations-without-exposing-source-code-to-it

@webknjaz
Copy link
Copy Markdown
Member Author

@webknjaz you said it is not working on Weblate. Not sure what's up, but have you considered setting on Weblate the input POT to the new branch?

That's exactly what I tried and it doesn't work the way I expected, it just sets a PR branch where Weblate tries to push stuff.
I need to think about it. I think moving the MO-files to a separate branch too and pointing RTD there would work.

TBH I don't know if you can set separate branches for POT and PO. If you can't, you might want to consider a different repository for translations. See https://docs.weblate.org/en/latest/faq.html#how-can-i-limit-weblate-access-to-only-translations-without-exposing-source-code-to-it

I wanted to avoid this.

@rffontenelle
Copy link
Copy Markdown
Contributor

Consider posting the issue on Weblate discussions.

@webknjaz webknjaz marked this pull request as ready for review December 4, 2021 11:40
@webknjaz
Copy link
Copy Markdown
Member Author

webknjaz commented Dec 4, 2021

Consider posting the issue on Weblate discussions.

I just realized that we can keep both the MOs and POT files in the translation/source branch and not main. Then, we'd publish the translated docs from that branch and Weblate would also send translation updates there w/o us needing to have those files in main. And also translation/source would be auto-updated from main continuously. So probably no need to raise this discussion anymore...

@webknjaz webknjaz force-pushed the maintenance/gha-i18n-pot branch from 0b37f79 to 1f40cfc Compare December 4, 2021 11:46
Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@webknjaz webknjaz enabled auto-merge December 4, 2021 11:47
@webknjaz webknjaz merged commit b6cd452 into pypa:main Dec 4, 2021
@webknjaz
Copy link
Copy Markdown
Member Author

webknjaz commented Dec 5, 2021

Turns out, there was a bug in this PR. Here's the hotfix: #1021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug or unintended behavior type: enhancement A self-contained enhancement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants