Merged
Conversation
webknjaz
reviewed
Jun 23, 2022
Member
webknjaz
left a comment
There was a problem hiding this comment.
I've put some suggestions below plus a portion of these changes has been merged via another recent PR making conflicts resolution necessary too.
henryiii
commented
Jun 23, 2022
webknjaz
reviewed
Aug 25, 2022
henryiii
commented
Aug 25, 2022
ghost
approved these changes
Oct 13, 2022
hugovk
reviewed
Mar 5, 2023
hugovk
reviewed
Mar 5, 2023
9cd13ba to
710dd53
Compare
Merged
Contributor
|
See #1221 to fix the linkcheck. |
710dd53 to
922f6a9
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
922f6a9 to
a4f8a0e
Compare
webknjaz
approved these changes
Mar 27, 2023
Member
webknjaz
left a comment
There was a problem hiding this comment.
Thanks for all the effort you've put into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the GHA guide a bit with non-controversial changes (hopefully). I think using pipx instead of the current setup would be simpler and is better practice, I might do that in a followup.
Changes: