Skip to content

chore: update GHA guide#1092

Merged
webknjaz merged 2 commits intopypa:mainfrom
henryiii:henryiii/fix/ghaguide
Mar 27, 2023
Merged

chore: update GHA guide#1092
webknjaz merged 2 commits intopypa:mainfrom
henryiii:henryiii/fix/ghaguide

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

@henryiii henryiii commented Jun 21, 2022

This updates the GHA guide a bit with non-controversial changes (hopefully). I think using pipx instead of the current setup would be simpler and is better practice, I might do that in a followup.

Changes:

  • Point out this works only for pure Python, link to cibuildwheel for binary packages
  • Use Python 3.x
  • Drop mention about needed pyproject.toml to use build and links to PEPs (it is backward compatible if it's missing)
  • Use more recent versions of actions and the tagged versions of all actions

@henryiii henryiii requested a review from webknjaz as a code owner June 21, 2022 20:20
Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put some suggestions below plus a portion of these changes has been merged via another recent PR making conflicts resolution necessary too.

Comment thread source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml Outdated
Comment thread source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml Outdated
Comment thread source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml Outdated
Comment thread source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml Outdated
Comment thread source/guides/github-actions-ci-cd-sample/publish-to-test-pypi.yml
@henryiii henryiii force-pushed the henryiii/fix/ghaguide branch 2 times, most recently from 9cd13ba to 710dd53 Compare March 13, 2023 14:23
@hugovk hugovk mentioned this pull request Mar 13, 2023
@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Mar 13, 2023

See #1221 to fix the linkcheck.

@henryiii henryiii force-pushed the henryiii/fix/ghaguide branch from 710dd53 to 922f6a9 Compare March 13, 2023 17:54
@webknjaz webknjaz enabled auto-merge March 27, 2023 15:08
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@webknjaz webknjaz force-pushed the henryiii/fix/ghaguide branch from 922f6a9 to a4f8a0e Compare March 27, 2023 15:09
Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the effort you've put into this!

@webknjaz webknjaz added type: enhancement A self-contained enhancement or new feature component: guides labels Mar 27, 2023
@webknjaz webknjaz merged commit 5668ae8 into pypa:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: guides type: enhancement A self-contained enhancement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants